Patch findwallets native search#16311
Closed
pettinarip wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
Bot
added
the
Status: Stale
wackerow
removed
the
Status: Stale
Member
|
Hey @pettinarip, curious how you want to move forward with this... as we discussed, this doesn't perfectly target the location of the wallet, but it does at least get spotted by a browser "Find" search, which is arguably better than now, since the user will at least know that the wallet is on the page somewhere. I'd be down to move forward as-is and iterate from here |
Member
Author
|
@wackerow yeah, thats fair. Not ideal but functionally better. I'll update the PR and get it ready. |
Contributor
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
Bot
added
the
Status: Stale
Member
Author
|
closing in favor of #18067 |
github-actions
Bot
added
the
abandoned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the recent introduction of the virtualized list (#16233), the native browser search (Ctrl+F) no longer works as expected. Items that are not currently visible are unmounted, so they cannot be found via the search.
This PR mitigates the issue by rendering “ghost” elements containing wallet names. This way, all wallet names remain discoverable with the native search. When matched, the user can scroll to the approximate position of the wallet. While not pixel-perfect, this at least ensures that users can locate wallets using the browser’s search functionality.
TODO
If it works, move the ghost list to its own component and memo it to avoid perf impact.